Prevent pull images for prometheus and grafana #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This patch add a new prometheus and grafana variable to allow install when the images already pulled on docker. Signed-off-by: Marcos Amorim <mamorim@redhat.com>
marcosmamorim
force-pushed
the
pull_images
branch
from
1aba133
to
126a729
Compare
|
@marcosmamorim apologies for the delay, here. Would you mind rebasing this against master? I've just got some fixes in for our CI. |
|
@zmc Thanks, I was think the best option for this fix is remove the parameter pull_images from the containter_start instead of create a new options, let me know what you think. Marcos Amorim |
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add a new prometheus and grafana variable to allow install when the images already pulled on docker.