repos: adds a endpoint to retrieve a deb or rpm repo file #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint can be used by clients to get the contents of a rpm repo or deb list file for a specific repo, allowing for clients to easily consume the repos built by chacra. The endpoint exists at two places: repo/$project/$ref/$sha1/$distro/$distro_version/repo/ repo/$project/$ref/$sha1/$distro/$distro_version/flavors/$flavor/repo/ Signed-off-by: Andrew Schoen <aschoen@redhat.com>
alfredodeza
reviewed
Oct 31, 2016
| return self.repo_obj | ||
|
|
||
| @expose('mako:repo.mako') | ||
| def repo(self): |
There was a problem hiding this comment.
for DEB distros you would need to accept a query arg that allows to pass in the distro needed. A combined DEB repo cannot know what repo file to work with.
There was a problem hiding this comment.
I don't think so because the endpoint where this exists will already know the distro and distro version. The url would look something like this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint can be used by clients to get the contents of
a rpm repo or deb list file for a specific repo, allowing for
clients to easily consume the repos built by chacra.
The endpoint exists at two places:
repo/$project/$ref/$sha1/$distro/$distro_version/repo/
repo/$project/$ref/$sha1/$distro/$distro_version/flavors/$flavor/repo/
Signed-off-by: Andrew Schoen aschoen@redhat.com