Add missing anticipation_timeout argument to PullPriorityQueue constructor #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor Signed-off-by: Taewoong Kim <taewoong.kim@sk.com>
|
@TaewoongKim Is it OK if we don't pull this into ceph immediately? There's a bit of work to check everything and we just did a pull not that long ago, so when possible I like to accumulate commits before the pull. But please let me know if you have any timing constraints. |
|
@ivancich OK, let me know if it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed adding anticipation_timeout argument for a constructor at the previous PR.
If this PR is merged I will make a ceph PR that makes anticipation timeout be configurable for ceph.
The code will be TaewoongKim/ceph@8f17269