Let user specify what libvirt networks to connect to.

Can use multiple networks, and can specify fixed MACs.
ceph · Jun 26, 2012 · de494ee · de494ee
1 parent 1da1a87
commit de494ee
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 4 deletions.
diff --git a/doc/examples/custom-networks.meta.yaml b/doc/examples/custom-networks.meta.yaml
@@ -0,0 +1,8 @@
+# You can explicitly choose what libvirt networks to connect the vm
+# to. Default is one interface in the ``default`` network, with a
+# randomly assigned MAC.
+downburst:
+  networks:
+    - source: green
+      mac: 52:54:00:42:42:42
+    - source: yellow
diff --git a/downburst/create.py b/downburst/create.py
@@ -55,11 +55,13 @@ def create(args):
         )
 
     ram = meta_data.get('downburst', {}).get('ram')
+    networks = meta_data.get('downburst', {}).get('networks')
     domainxml = template.domain(
         name=args.name,
         disk_key=clone.key(),
         iso_key=iso_vol.key(),
         ram=ram,
+        networks=networks,
         )
     dom = conn.defineXML(etree.tostring(domainxml))
     dom.create()

diff --git a/downburst/template.py b/downburst/template.py
@@ -40,6 +40,7 @@ def domain(
     disk_key,
     iso_key,
     ram=None,
+    networks=None,
     ):
     with pkg_resources.resource_stream('downburst', 'template.xml') as f:
         tree = etree.parse(f)
@@ -74,4 +75,27 @@ def domain(
         (memory,) = tree.xpath('/domain/memory')
         memory.text = '{ram:d}'.format(ram=ram)
 
+    # <interface type='network'>
+    #   <source network='default'/>
+    #   <model type='virtio'/>
+    # </interface>
+    if networks is None:
+        networks = [{}]
+    for net in networks:
+        net_elem = etree.SubElement(
+            devices,
+            'interface',
+            type='network',
+            )
+        etree.SubElement(net_elem, 'model', type='virtio')
+        etree.SubElement(
+            net_elem,
+            'source',
+            network=net.get('source', 'default'),
+            )
+        mac = net.get('mac')
+        if mac is not None:
+            # <mac address='52:54:00:01:02:03'/>
+            etree.SubElement(net_elem, 'mac', address=mac)
+
     return tree
diff --git a/downburst/template.xml b/downburst/template.xml
@@ -26,10 +26,10 @@
     <!--   <target dev='hdc' bus='ide'/> -->
     <!--   <readonly/> -->
     <!-- </disk> -->
-    <interface type='network'>
-      <source network='default'/>
-      <model type='virtio'/>
-    </interface>
+    <!-- <interface type='network'> -->
+    <!--   <source network='default'/> -->
+    <!--   <model type='virtio'/> -->
+    <!-- </interface> -->
     <serial type='pty'>
       <target port='0'/>
     </serial>