Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left over ceph_preview tags from test related files #799

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Dec 19, 2022

These are left overs from v0.13.0, v0.17.0 and v0.19.0 releases where we missed to remove preview tags when following APIs were promoted to stable.

  • API.AddUserCap and API.RemoveUserCap in e23ab12
  • API.LinkBucket and API.UnlinkBucket in 9d74c3c
  • IOContext.SetAllocationHint in efa832c

Fixes #798

These are left overs from v0.13.0 and v0.17.0 releases where we missed
to remove preview tag when corresponding APIs were promoted to stable.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
This is a left over from v0.19.0 release where we missed to remove
preview tag when corresponding API was promoted to stable.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 changed the title Remove left over ceph_preview tags from test files Remove left over ceph_preview tags from test related files Dec 19, 2022
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Dec 19, 2022
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mergify mergify bot merged commit a0524ac into ceph:master Dec 19, 2022
@anoopcs9 anoopcs9 deleted the rm-preview-tag branch December 20, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined: AllocHintFlags
2 participants