Go: bump tested Go version to 1.19.5

[ansiwen]

This bumps the Go version of the test container to 1.19.5, which is the oldest supported Go version as of now.

The go.mod file (including an upgrade of its dependencies) and the revive environment is bumped to 1.19 as well.

Signed-off-by: Sven Anderson sven@redhat.com

Closes: #825

[phlogistonjohn]

The gist of it looks good, but the tests are failing. Ping me once the test failures are resolved. Thanks!

[ansiwen]

@phlogistonjohn apparently the new gofmt has it's own idea how comments have to look like. :-/

Also I changed the go.mod version to 1.19, because I found contradicting information. In go help mod tidy it says:

By default, tidy acts as if the -compat flag were set to the
version prior to the one indicated by the 'go' directive in the go.mod
file.

But in https://go.dev/ref/mod#go-mod-file-go it says:

For packages within the module, the compiler rejects use of language features introduced after the version specified by the go directive. For example, if a module has the directive go 1.12, its packages may not use numeric literals like 1_000_000, which were introduced in Go 1.13.

The second behavior seems more important to us.

[ansiwen]

Also the other jobs are failing because of the VCS stamping. I will continue on that later.

[phlogistonjohn]

@phlogistonjohn apparently the new gofmt has it's own idea how comments have to look like. :-/

sigh OK, it looks very mechanical (mostly just increased indents) and so I'll trust the change w/o going over it with a fine toothed comb.

Also I changed the go.mod version to 1.19, because I found contradicting information. In go help mod tidy it says:

By default, tidy acts as if the -compat flag were set to the
version prior to the one indicated by the 'go' directive in the go.mod
file.

But in https://go.dev/ref/mod#go-mod-file-go it says:

For packages within the module, the compiler rejects use of language features introduced after the version specified by the go directive. For example, if a module has the directive go 1.12, its packages may not use numeric literals like 1_000_000, which were introduced in Go 1.13.

The second behavior seems more important to us.

Indeed! Good catch, thanks.

Also the other jobs are failing because of the VCS stamping. I will continue on that later.

OK, that's fine. This is new to me as well and I'll read up a bit on it too.

[phlogistonjohn]

golang/go#51723 turned up in my search. So it seems that because we build implements tool it kicks in but wouldn't for our runs of go test.

Sounds like we need the -buildvcs=auto flag sprinkled around?

[ansiwen]

Yeah, let's finish this after tue release then.

[ansiwen]

Ok, finally CI is succeeding. I had to use GOFLAGS to disable the VCS stamps, there is not other environment variable. Oh, and auto is the default, which is obviously not working. So we need false.

[ansiwen]

@phlogistonjohn PTAL, and better review the individual commits.

[phlogistonjohn]

LGTM, thanks!