Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Add missing GOPROXY build argument #843

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Mar 8, 2023

Previously, commit 102616b tried to expose GOPROXY env var from developer environment by specifying it as environment variable or build argument to container build process. But using --build-arg to container build command would require the same to be referenced inside Dockerfile/Containerfile so that the following warning can be avoided:

[Warning] one or more build args were not consumed: [GOPROXY]

Previously, commit 102616b tried to
expose GOPROXY env var from developer environment by specifying it as
environment variable or build argument to container build process. But
using --build-arg to container build command would require the same to
be referenced inside Dockerfile/Containerfile so that the following
warning can be avoided:

[Warning] one or more build args were not consumed: [GOPROXY]

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Mar 8, 2023
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 7607fd8 into ceph:master Mar 8, 2023
@anoopcs9 anoopcs9 deleted the goproxy-build-arg branch April 10, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants