rbd: Add locking rbd APIs #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Ladha
force-pushed
the
issue275/rbd_locking_api
branch
from
50cde5a
to
0c78484
Compare
anoopcs9
reviewed
Mar 31, 2023
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
Nikhil-Ladha
force-pushed
the
issue275/rbd_locking_api
branch
from
0c78484
to
6620acb
Compare
|
Thanks for the PR, just a heads up that we are going to release tomorrow but this PR will not be included, it should be no problem to land it in the following release. |
anoopcs9
requested changes
Apr 12, 2023
anoopcs9
reviewed
Apr 12, 2023
Nikhil-Ladha
force-pushed
the
issue275/rbd_locking_api
branch
from
6620acb
to
77c6029
Compare
Added new locking APIs for the rbd component named `rbd_lock_acquire`, `rbd_lock_break`, `rbd_lock_release`, `rbd_lock_get_owners`, `rbd_is_exclusive_lock_owner` along with supporting TCs. Fixes: ceph#275 Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Nikhil-Ladha
force-pushed
the
issue275/rbd_locking_api
branch
from
77c6029
to
d65aae7
Compare
anoopcs9
approved these changes
Apr 13, 2023
anoopcs9
added
the
API
phlogistonjohn
requested changes
Apr 13, 2023
There was a problem hiding this comment.
I have exactly one thing to discuss, everything else looks good. Before I approve I want to understand the for loop in LockGetOwners. It may be fine, but I want to understand the thought process behind it first. If you do think it can be improved by using WithSizes, go ahead with the change :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new locking APIs for the rbd component named
rbd_lock_acquire,rbd_lock_break,rbd_lock_release,rbd_lock_get_owners,rbd_is_exclusive_lock_owneralong with supporting TCs.Fixes: #274
Fixes: #275
Checklist
//go:build ceph_previewmake api-updateto record new APIs