rbd: document SparsifyWithProgress callback's arguments #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in ceph#851, we wanted to fully document the arguments the callback function is expected to be called with. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
added
the
no-API
5 tasks
We overlooked this in review, before this makes it into a release let's remove the referential redundancy with rapidity. Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
Adding extended-review label to give @ansiwen a chance to look at the change. Please remove the label once you approve for automatic merge. |
anoopcs9
added
the
extended-review
ansiwen
approved these changes
Apr 5, 2023
phlogistonjohn
removed
the
extended-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #851, we wanted to fully document the arguments the callback function is expected to be called with.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.