Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: Add futime cephfs API #869

Merged
merged 1 commit into from
Apr 25, 2023
Merged

cephfs: Add futime cephfs API #869

merged 1 commit into from
Apr 25, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Apr 14, 2023 •
edited

Added a new cephfs API named ceph_futime

Fixes: #252

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@Nikhil-Ladha Nikhil-Ladha changed the title cephfs: Add ceph_futime API cephfs: Add futime cephfs API Apr 14, 2023
phlogistonjohn
phlogistonjohn requested changes Apr 17, 2023
View reviewed changes
cephfs/file_ops.go Outdated Show resolved Hide resolved
cephfs/file_ops.go Outdated Show resolved Hide resolved
phlogistonjohn
phlogistonjohn reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one optional suggestion. If you do not want to take it or this PR, say so and I will change my review to an approval.

cephfs/file_ops.go Outdated Show resolved Hide resolved
@Nikhil-Ladha
cephfs: Add futime cephfs API
5d1d02e 
Added a new cephfs API named `ceph_futime`

Fixes: ceph#252

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
phlogistonjohn
phlogistonjohn approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working with me on the feedback!

@phlogistonjohn phlogistonjohn added the API This PR includes a change to the public API of a go-ceph package label Apr 24, 2023
@mergify mergify bot merged commit 46cf8b0 into ceph:master Apr 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing cephfs API components: function ceph_futime
3 participants
@Nikhil-Ladha @anoopcs9 @phlogistonjohn