Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: Add futimes cephfs API #875

Merged
merged 1 commit into from
May 18, 2023
Merged

cephfs: Add futimes cephfs API #875

merged 1 commit into from
May 18, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

Added a new cephfs API named ceph_futimes

Fixes: #254

Signed-off-by: Nikhil-Ladha nikhilladha1999@gmail.com

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Apr 28, 2023
phlogistonjohn
phlogistonjohn requested changes May 3, 2023
View reviewed changes
cephfs/file_ops.go Outdated Show resolved Hide resolved
@Nikhil-Ladha
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 9, 2023

rebase

❌ Unable to rebase: user Nikhil-Ladha is unknown.

Please make sure Nikhil-Ladha has logged in Mergify dashboard.

@Nikhil-Ladha
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 9, 2023

rebase

❌ Base branch update has failed

Nikhil-Ladha token is invalid, make sure Nikhil-Ladha can still log in on the Mergify dashboard.
err-code: 3DCA0

@mergify
Copy link

mergify bot commented May 12, 2023

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@Nikhil-Ladha
Copy link
Contributor Author

Awaiting review @phlogistonjohn and @anoopcs9 😅

phlogistonjohn
phlogistonjohn approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Nikhil-Ladha
cephfs: Add futimes cephfs API
3dec8b9 
Added a new cephfs API named `ceph_futimes`

Fixes: ceph#254

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@mergify mergify bot merged commit 15ede44 into ceph:master May 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing cephfs API components: function ceph_futimes
3 participants
@Nikhil-Ladha @anoopcs9 @phlogistonjohn