rbd: include details for parent image in the trash

[nixpanic]

When a parent image has been removed, it will linger in the trash until all siblings are gone. The image is not accessible through it's name anymore, only through its ID.

The ImageSpec that is returned by Image.GetParent() now contains the Trash boolean and the ImageID to identify if the image is in the trash, and use OpenImageById() to access the removed parent image.

Related-to: ceph/ceph-csi#4013

Checklist

• Added tests for features and functional changes
• Public functions and types are documented
• Standard formatting is applied to Go code
• Is this a new API? Added a new file that begins with //go:build ceph_preview
• Ran make api-update to record new APIs

[phlogistonjohn]

Marked as an API change for review purposes. Change itself extends an existing type with new fields.

[phlogistonjohn]

Change generally looks good to me and I'm willing to approve as-is, but first I want to ask. Would you mind completing the object and putting all fields present in rbd_linked_image_spec_t into the Go equivalent?

As of nautilus the fields are:

typedef struct {
  int64_t pool_id;
  char *pool_name;
  char *pool_namespace;
  char *image_id;
  char *image_name;
  bool trash;
} rbd_linked_image_spec_t;

After your change we still lack pool_id and pool_namespace. I think it would be nice to proactively complete the set so that the next person who needs one of those doesn't need to file a PR :-)

What do you think?

[phlogistonjohn]

Also, we can ignore failures in the CI against ceph main. This is due to a general infra issues on the ceph side related to nfs-ganesha builds.

[Rakshith-R]

Thanks !
It looks good to me,
added a small suggestion to check for ImageID too.

[Rakshith-R]

Lgtm !

[phlogistonjohn]

LGTM, thanks!

[anoopcs9]

Should we add an additional check to ensure that parent is no longer accessible by name but via ID(using OpenImageById()) as mentioned in the commit message?

Pull request has been modified.

[nixpanic]

Should we add an additional check to ensure that parent is no longer accessible by name but via ID(using OpenImageById()) as mentioned in the commit message?

That was taken from the discussion in ceph/ceph-csi#4013. I do not think we need to validate this particular RBD behavior. Possibly it could be added to a test that verifies the Trash() function.

[anoopcs9]

lgtm.

[phlogistonjohn]

LGTM