Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs: made ENOENT a public error #940

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

riya-singhal31
Copy link
Contributor

this commit renames ErrNoEntry of cephfs
to ErrNotExist and making it public allowing
other projects to access this.

Signed-off-by: Riya Singhal rsinghal@redhat.com

this commit renames ErrNoEntry of cephfs
to ErrNotExist and making it public allowing
other projects to access this.

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
@ansiwen ansiwen added the API This PR includes a change to the public API of a go-ceph package label Nov 9, 2023
@ansiwen
Copy link
Collaborator

ansiwen commented Nov 9, 2023

Technically that is a API change, but our "preview" scheme doesn't support exported constants, so I guess this is fine as it is. WDYT @phlogistonjohn ?

@phlogistonjohn
Copy link
Collaborator

I think it's probably OK to bypass the preview process because a) its backwards compatible and b) there's not much one could want changed during a preview period.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Naming schme matches the name used in rbd.

Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 2852a13 into ceph:master Nov 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants