Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ceph squid CI jobs #963

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add ceph squid CI jobs #963

merged 3 commits into from
Mar 7, 2024

Conversation

anoopcs9
Copy link
Collaborator

fixes #962

@phlogistonjohn
Copy link
Collaborator

Thanks for taking this on! Most of the changes look good. I would suggest that once there's a squid image available we can comment out the "squid release" job but keep the pre-squid job, merge it in that state, and then uncomment the squid release ci job when squid is properly released. Sound OK?

@anoopcs9
Copy link
Collaborator Author

Thanks for taking this on! Most of the changes look good. I would suggest that once there's a squid image available we can comment out the "squid release" job but keep the pre-squid job, merge it in that state, and then uncomment the squid release ci job when squid is properly released. Sound OK?

Fine by me.

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Mar 6, 2024

@Mergifyio rebase

Copy link

mergify bot commented Mar 6, 2024

rebase

✅ Branch has been successfully rebased

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Add CEPH_VERSION values for squid and pre-squid. This will allow
building and testing with ceph squid images.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 marked this pull request as ready for review March 6, 2024 15:58
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Mar 6, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 708a740 into ceph:master Mar 7, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the add-squid-ci branch March 9, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need squid branch support
2 participants