Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Dockerfile & containerized pulpito-ng #22

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

kamoltat
Copy link
Member

Motivation:

We need a way to connect pulpito-ng
with teuthology-api + all other teuthology services. Currently, we make use of docker containers to create a development environment for teuthology-api and other teuthology services.

Solution:

Created a Dockerfile and added a section in the README file describing the process of connecting pulpito-ng with otheer teuthology services such that we will be able to containerize pulpito-ng and develop it along side other services.

@kamoltat kamoltat added documentation Improvements or additions to documentation enhancement Making existing feature better labels Jun 24, 2023
@kamoltat kamoltat requested a review from zmc June 24, 2023 19:48
@kamoltat kamoltat self-assigned this Jun 24, 2023
Dockerfile Outdated Show resolved Hide resolved
@kamoltat kamoltat force-pushed the wip-ksirivad-docker-file branch 2 times, most recently from 06c2be4 to 4710aad Compare July 5, 2023 15:45
@kamoltat
Copy link
Member Author

@zmc should we try to merge this? I think we agreed on keep the docker-compose stuff for now so this will help the interns to develop easier.

@zmc
Copy link
Member

zmc commented Jul 17, 2023

@kamoltat yeah, I still want to try restoring the docs subdir before merging; I just haven't had a chance to yet. I'll mark this as a draft until then.

@zmc zmc marked this pull request as draft July 17, 2023 20:26
@kamoltat
Copy link
Member Author

@zmc can we merge this first since it will be easier for the interns to run pulpito-ng in a container with other services, so that can start working on integrating pulpitp-ng with teuthology-api.

@zmc
Copy link
Member

zmc commented Jul 18, 2023

@kamoltat 🤦 when I saw your comment I somehow thought you were talking about the teuthology PR - I have no idea why. Sorry!

This can be merged now.

@zmc zmc marked this pull request as ready for review July 18, 2023 15:51
README.md Outdated Show resolved Hide resolved
@zmc
Copy link
Member

zmc commented Jul 21, 2023

Looks like we have a merge conflict @kamoltat - should be an easy one to fix, though

@zmc
Copy link
Member

zmc commented Jul 21, 2023

I set up automated container builds for this repo, so once we get this PR merged we will have containers available here: https://quay.io/repository/ceph-infra/pulpito-ng

Motivation:

We need a way to connect `pulpito-ng`
with `teuthology-api` + all other teuthology services.
Currently, we make use of docker containers to create
a development environment for `teuthology-api` and
other teuthology services.

Solution:

Created a Dockerfile and added a section in the README
file describing the process of connecting `pulpito-ng`
with otheer teuthology services such that we will be able
to containerize `pulpito-ng` and develop it along side
other services.

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
@kamoltat
Copy link
Member Author

@zmc should be good

@zmc zmc merged commit 53aa517 into ceph:main Jul 25, 2023
1 check passed
@zmc
Copy link
Member

zmc commented Jul 25, 2023

Quay seems to be broken at the moment; the build started 40min ago and hasn't completed. I started a second one and it appears hung as well.

@zmc
Copy link
Member

zmc commented Jul 25, 2023

Built and pushed manually to: https://quay.ceph.io/repository/ceph/pulpito-ng
We'll need a real solution, of course, but this is something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Making existing feature better
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants