Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling and fix a crash #65

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Improve error handling and fix a crash #65

merged 4 commits into from
Feb 22, 2024

Conversation

zmc
Copy link
Member

@zmc zmc commented Oct 20, 2023 •
edited
Loading

@render
Copy link

render bot commented Oct 20, 2023

Your Render PR Server URL is https://pulpito-ng-pr-65.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckpcnje2eoec73e8ebeg.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit 5d91123
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/65d6733c34e21b0008e0b906
😎 Deploy Preview https://deploy-preview-65--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VallariAg
Copy link
Member

Wow, react-error-boundary looks like a really amazing library to handle all errors!

Maybe we can word-wrap CodeBlock component? Don't know if we would want that for job details's CodeBlock too.
image
(screenshot when I undo the crash fix to see the ErrorFallback in action)

@VallariAg
Copy link
Member

I just noticed that we didn't merge this PR, sorry. This looks like a useful feature to have, so we can merge it and text wrap can be a low hanging fruit for later (probably shouldn't hold important PR approvals for text-wraps haha!). I'll approve this after the needed rebase - already tested locally.
Thank you!

@zmc
npm i react-error-boundary
0e59c03 
Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc
Add CodeBlock component
0e2bd8f 
Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc
Add ErrorFallback component
52d509c 
And wrap both the main app body and the DataGrid component with it.

Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc
JobList: Filter jobs with a nullish id
5d91123 
Paddles should not give us broken job objects like this, but we should also
not crash if it does :)

Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc
Copy link
Member Author

zmc commented Feb 21, 2024

@VallariAg rebased!

@zmc zmc merged commit 07e51f2 into main Feb 22, 2024
7 checks passed
@zmc zmc deleted the null-jobid branch February 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VallariAg VallariAg VallariAg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zmc @VallariAg