This repository has been archived by the owner on May 6, 2021. It is now read-only.
Bug fixes for full sync and a few other data sync cases #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
…region() works Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
…is not found Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
The decorator for translating boto exceptions needs to return explicitly, or it will lose the return value of the original function, and cause full sync to fail for objects that aren't in the bucket index log. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
This way we catch objects that were uploaded before zones or data logs were set up. If there are actually no objects in the bucket, the bucket listing will tell us that. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Need to esacpe the x-amz-copy-source header. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
We still want to retry later, since 500 could be the gateway timing out, or it being upgraded to fix a bug, etc. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
There's a very narrow window in which our connection sending the copy request could fail before radosgw records the op state, and we query the op state in that time. Retrying later at that point is fine, and avoids a long timeout if there is a bug causing us to reach this point without the op state ever being recorded. This race hasn't been observed in practice. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
|
Tests passed for this pull request. |
|
This includes #11 as well |
alfredodeza
added a commit
that referenced
this pull request
Dec 8, 2014
Bug fixes for full sync and a few other data sync cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the data sync tests that are updated to
handle full sync now.