The semantic analysis for nested-calls of non-aggregate functions wit… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h aggregate function was wrong, this PR fix several issues. first it rejects illegal queries, second it executes correctly these use-cases. Signed-off-by: gal salomon <gal.salomon@gmail.com>
…wrong combinations of aggregation projection and non-aggregation projection Signed-off-by: gal salomon <gal.salomon@gmail.com>
…rect execution of nested&complex aggregation queries Signed-off-by: gal salomon <gal.salomon@gmail.com>
…e /reolve_name/ of functions is now done upon semnatic phase before execution; semantic phase should be more the name-resolving(will be on later phase); [ #42 ] Signed-off-by: gal salomon <gal.salomon@gmail.com>
|
1 closing the gap of executing correctly nested aggregation functions, including semantic analysis to query, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h aggregate function was wrong, this PR fix several issues. first it rejects illegal queries, second it executes correctly these use-cases.
Signed-off-by: gal salomon gal.salomon@gmail.com