Update CIP-82 to use CIP-88 namespace #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
reviewed
Mar 1, 2021
|
Yes good idea, I added the requirement to the header. |
|
But do you mind also adding CIP-88 as part of this PR? Would be good if it's finable in the INDEX.md if it's a requirement here. |
|
I could but I thought the flow would be first discussing/merging CIP 88 and then updating 82 and 85, no? Basically I'd like to make sure possible comments about 88 are addressed before making further changes to other CIPs. I don't mind adding 88 in this PR if it makes things simpler, just want to make sure it doesn't slow the process down. |
|
I think it's fine to merge drafts before much discussion. Drafts can always easily be updated with a new PR if needed. |
oed
approved these changes
Mar 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIP-88 issue: #88