Feat/errors helpers pkh eth #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachferland
force-pushed
the
feat/errors-helpers-pkh-eth
branch
3 times, most recently
from
e293f23
to
b5370c1
Compare
zachferland
force-pushed
the
feat/errors-helpers-pkh-eth
branch
from
b5370c1
to
d107332
Compare
oed
approved these changes
Jun 13, 2023
packages/did-session/README.md
Outdated
| import { DIDSession, getAccountIdByDID } from 'did-session' | ||
| import { EthereumWebAuth } from '@didtools/pkh-ethereum' | ||
|
|
||
| const ethProvider = // import/get your web3 eth provider |
There was a problem hiding this comment.
Might be worth mentioning https://eips.ethereum.org/EIPS/eip-1193 somewhere in our docs to be extra clear.
There was a problem hiding this comment.
yeah ill add that to the did-session and eth-pkh docs, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small things
reminded need to add tests in most of these libraries still