feat: Pass issuer to verifyJWS #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
requested changes
Jul 12, 2021
src/did.ts
Outdated
| const issuerResolution = await this.resolve(issuerUrl) | ||
| const controllerProperty = issuerResolution.didDocument?.controller | ||
| const controllers = extractControllers(controllerProperty) | ||
| const signerIsController = controllers.some((controller) => controller === signerDid) |
Comment on lines
+246
to
+248
| const signerDid = didResolutionResult.didDocument?.id | ||
| if (options.issuer && options.issuer !== signerDid) { | ||
| const issuerUrl = didWithTime(options.issuer, options.atTime) |
There was a problem hiding this comment.
Maybe break this and the timecheckEnabled conditional into helper functions?
There was a problem hiding this comment.
TBH, I would like to accumulate a little more weirdness like this, and extract verifyJWS into own verification service. It clearly does not belong here as a method of DID object.
There was a problem hiding this comment.
Well, ideally most of this logic could move into the did-jwt package. Which btw should be renamed did-jose at some point: decentralized-identity/did-jwt#170
There was a problem hiding this comment.
I really want to accumulate weirdness here nevertheless to guide the further changes.
Co-authored-by: Joel Thorstensson <oed@3box.io>
Signed-off-by: ukstv <sergey@ukstv.me>
oed
reviewed
Jul 12, 2021
| @@ -249,7 +249,7 @@ export class DID { | |||
| const issuerResolution = await this.resolve(issuerUrl) | |||
| const controllerProperty = issuerResolution.didDocument?.controller | |||
| const controllers = extractControllers(controllerProperty) | |||
| const signerIsController = controllers.some((controller) => controller === signerDid) | |||
| const signerIsController = signerDid ? controllers.includes(signerDid) : false | |||
oed
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
did-Ais the controller ofdid-Ba signature performed by A should be seen as valid if B is the issuer. We use the controller property in DID documents to allow for Safe and NFT DIDs.