Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDB-2492: Add support for parsing index directive #128

Merged
merged 2 commits into from Jul 20, 2023
Merged

CDB-2492: Add support for parsing index directive #128

merged 2 commits into from Jul 20, 2023

Conversation

dbcfd
Copy link
Contributor

@dbcfd dbcfd commented May 25, 2023

No description provided.

@dbcfd dbcfd requested a review from PaulLeCam May 25, 2023 21:39
PaulLeCam
PaulLeCam requested changes May 31, 2023
View reviewed changes
packages/types/src/index.ts Outdated Show resolved Hide resolved
packages/devtools/src/composite.ts Outdated Show resolved Hide resolved
packages/devtools/src/composite.ts Outdated Show resolved Hide resolved
packages/devtools/test/schema.test.ts Outdated Show resolved Hide resolved
@PaulLeCam PaulLeCam mentioned this pull request Jun 27, 2023
Closed
PaulLeCam
PaulLeCam requested changes Jul 10, 2023
View reviewed changes
packages/types/src/index.ts Outdated Show resolved Hide resolved
packages/devtools/src/schema/parser.ts Outdated Show resolved Hide resolved
PaulLeCam
PaulLeCam reviewed Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly wondering about the different version range constraints set in the different packages

packages/devtools/package.json Show resolved Hide resolved
packages/devtools/src/composite.ts Outdated Show resolved Hide resolved
packages/jest-environment-composedb/package.json Outdated Show resolved Hide resolved
packages/server/package.json Show resolved Hide resolved
@dbcfd dbcfd force-pushed the cdb-2492-index-directive branch 2 times, most recently from 7dec3fc to 83e5bff Compare July 18, 2023 17:09
@dbcfd dbcfd requested review from stbrody and PaulLeCam July 18, 2023 19:20
stbrody
stbrody reviewed Jul 19, 2023
View reviewed changes
packages/cli/globalSetup.js Show resolved Hide resolved
packages/cli/package.json Show resolved Hide resolved
packages/client/test/client.test.ts Outdated Show resolved Hide resolved
packages/devtools/src/composite.ts Show resolved Hide resolved
packages/devtools/src/schema/typeDefinitions.ts Show resolved Hide resolved
packages/devtools/src/schema/types.ts Outdated Show resolved Hide resolved
packages/jest-environment-composedb/index.js Show resolved Hide resolved
@stbrody stbrody mentioned this pull request Jul 19, 2023
Merged
@dbcfd dbcfd requested a review from stbrody July 19, 2023 19:26
willex
willex approved these changes Jul 20, 2023
View reviewed changes
Copy link

@willex willex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stbrody stbrody requested review from PaulLeCam and removed request for PaulLeCam July 20, 2023 15:40
@oed oed merged commit f991743 into main Jul 20, 2023
13 checks passed
@oed oed deleted the cdb-2492-index-directive branch July 20, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willex willex willex approved these changes

@stbrody stbrody Awaiting requested review from stbrody

@PaulLeCam PaulLeCam Awaiting requested review from PaulLeCam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dbcfd @PaulLeCam @stbrody @willex @oed