CommonJS-only setup #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # apps/developers/package.json # apps/self.id/package.json # apps/self.id/src/auth.ts # apps/self.id/src/pages/_app.tsx # docs/modules/framework.md # docs/modules/multiauth.md # docs/modules/react.md # docs/modules/ui.md # package.json # packages/core/package.json # packages/framework/package.json # packages/framework/src/index.ts # packages/multiauth/package.json # packages/multiauth/src/components/Modal.tsx # packages/multiauth/src/components/ModalItem.tsx # packages/multiauth/src/connectors/fortmatic.ts # packages/multiauth/src/connectors/injected.ts # packages/multiauth/src/connectors/portis.ts # packages/multiauth/src/connectors/torus.ts # packages/multiauth/src/connectors/walletConnect.ts # packages/multiauth/src/index.ts # packages/multiauth/src/networks.ts # packages/multiauth/test/connectors.test.ts # packages/multiauth/test/hooks.test.tsx # packages/react/package.json # packages/react/src/index.ts # packages/react/src/storage.ts # packages/ui/package.json # packages/ui/src/index.ts # packages/ui/src/theme.ts # packages/ui/test/__snapshots__/AvatarPlaceholder.test.tsx.snap # packages/web/package.json # templates/next-notes-typescript/next-env.d.ts # templates/next-notes-typescript/next.config.js # templates/next-notes-typescript/package.json # templates/next-notes-typescript/src/model.json # templates/next-notes-typescript/src/pages/_app.tsx # templates/webpack-basic-typescript/package.json # templates/webpack-basic-typescript/webpack.config.js # templates/webpack-basic/package.json # templates/webpack-basic/webpack.config.js # yarn.lock
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/3box/self-id/8fbMH8CTrppy29PunyVoTe8tKFit |
oed
reviewed
Feb 25, 2022
| @@ -5,7 +5,7 @@ | |||
| "scripts": { | |||
| "docusaurus": "docusaurus", | |||
| "start": "docusaurus start", | |||
| "build": "docusaurus build", | |||
| "--build": "docusaurus build", | |||
There was a problem hiding this comment.
To disable it, there seems to be some issues with the Docusaurus build but as we're not currently using this, I don't think it's worth spending time fixing.
| @@ -1,31 +1,33 @@ | |||
| { | |||
| "name": "self.id-template-webpack-basic-typescript", | |||
| "version": "0.1.0", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
Why does this change from 0.1.0to 0.0.0?
There was a problem hiding this comment.
Just for consistency with the other templates, the version doesn't matter here, we just need to set one to avoid having npm warn about it
| @@ -1,27 +1,29 @@ | |||
| { | |||
| "name": "self.id-template-webpack-basic", | |||
| "version": "0.1.0", | |||
| "version": "0.0.0", | |||
oed
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the issue with CommonJS imports in #53 is due to having dual CJS and ESM exports. As 3ID Connect only exports CJS, imports from ESM versions of the consuming packages fail.
The migration to ESM across the stack is ongoing but not ready yet, so in the meantime the alternative would be to go CJS-only to avoid this situation.
This mostly affects the image imports in multiauth, that require extra configuration now when using Next.js.
I also moved the
vite-basictemplate and removed it from the list in the README, as it only supports ESM.How Has This Been Tested?