chore(ci): Test against all supported dependency versions #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
force-pushed
the
test-against-all-supported-dependency-versions
branch
8 times, most recently
from
39f2faa
to
5dca3e8
Compare
Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
force-pushed
the
test-against-all-supported-dependency-versions
branch
from
5dca3e8
to
e46d34e
Compare
Signed-off-by: Andrew Haines <haines@cerbos.dev>
Earlier versions fail to load the `protovalidate` extension field descriptors with "field with proto3_optional was not in a oneof (buf.validate.priv.field)". protocolbuffers/upb#1034 Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
force-pushed
the
test-against-all-supported-dependency-versions
branch
from
702fe61
to
346cbb3
Compare
charithe
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating the protobuf code in #156 dropped some backwards-compatibility code from the generated files, and I realised that our CI only tests against the latest versions of the
grpcandgoogle-protobufgems so we wouldn't catch if this meant we needed to increase the minimum supported version of our dependencies.As it turns out, dropping the backwards-compatibility code didn't cause any issues, but the switch to
protovalidatedid. Versions ofgoogle-protobufprior to 3.21.12 cannot load their proto descriptors, failing withThis PR expands the test matrix to cover all the latest minor versions within our stated compatibility ranges, and increases the
google-protobufversion requirement to 3.21.12+.