Address reviews

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
cerbos · Apr 5, 2023 · 2c42c61 · 2c42c61
1 parent 2475881
commit 2c42c61
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/cmd/cerbos/compile/compile.go b/cmd/cerbos/compile/compile.go
@@ -11,10 +11,6 @@ import (
 	"os"
 	"os/signal"
 
-	"github.com/cerbos/cerbos/cmd/cerbos/compile/internal/verification"
-
-	"github.com/cerbos/cerbos/cmd/cerbos/compile/internal/verification"
-
 	"github.com/alecthomas/kong"
 	"github.com/fatih/color"
 	"github.com/pterm/pterm"
@@ -25,6 +21,7 @@ import (
 	internalcompile "github.com/cerbos/cerbos/cmd/cerbos/compile/internal/compilation"
 	"github.com/cerbos/cerbos/cmd/cerbos/compile/internal/flagset"
 	"github.com/cerbos/cerbos/cmd/cerbos/compile/internal/lint"
+	"github.com/cerbos/cerbos/cmd/cerbos/compile/internal/verification"
 	"github.com/cerbos/cerbos/internal/compile"
 	"github.com/cerbos/cerbos/internal/engine"
 	"github.com/cerbos/cerbos/internal/outputcolor"

diff --git a/cmd/cerbos/compile/internal/flagset/format.go b/cmd/cerbos/compile/internal/flagset/format.go
@@ -17,7 +17,7 @@ type VerificationOutputFormat string
 
 func (v *VerificationOutputFormat) Validate() error {
 	if !(*v == "tree" || *v == "list" || *v == "json" || *v == "junit") {
-		return fmt.Errorf("available options are tree, list, json or junit")
+		return fmt.Errorf("valid options are tree, list, json or junit")
 	}
 
 	return nil

diff --git a/docs/modules/cli/pages/cerbos.adoc b/docs/modules/cli/pages/cerbos.adoc
@@ -55,19 +55,18 @@ Arguments:
   <dir>    Policy directory
 
 Flags:
-  -h, --help                         Show context-sensitive help.
+  -h, --help                       Show context-sensitive help.
       --version
 
-      --ignore-schemas               Ignore schemas during compilation
-      --tests=STRING                 Path to the directory containing tests. Defaults to policy directory.
-      --run=STRING                   Run only tests that match this regex
-      --skip-tests                   Skip tests
-  -o, --output="tree"                Output format (tree,list,json)
-      --test-output="unspecified"    Test output format. If unspecified matches the value of the output flag. (unspecified,tree,list,json,junit)
-      --color=COLOR                  Output color level (auto,never,always,256,16m). Defaults to auto.
-      --no-color                     Disable colored output
-      --verbose                      Verbose output on test failure
-
+      --ignore-schemas             Ignore schemas during compilation
+      --tests=STRING               Path to the directory containing tests. Defaults to policy directory.
+      --run=STRING                 Run only tests that match this regex
+      --skip-tests                 Skip tests
+  -o, --output="tree"              Output format (tree,list,json)
+      --test-output=TEST-OUTPUT    Test output format. If unspecified matches the value of the output flag. (tree,list,json,junit)
+      --color=COLOR                Output color level (auto,never,always,256,16m). Defaults to auto.
+      --no-color                   Disable colored output
+      --verbose                    Verbose output on test failure
 ----
 
 [#healthcheck]