-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change deprecated OTel jaeger exporter #1784
Comments
Hey I can take this issue |
Please do. Looking forward to receiving the PR. |
Guys, I found this in the releases The go.opentelemetry.io/otel/exporters/jaeger package is deprecated. I will make implementation with "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" that's okay with us? |
We already support otlptracegrpc so I don't think there is anything to be done for this issue, other than we may wish to mark the jaeger exporter as deprecated in our tracing configuration so that we can remove it in a future release. |
Yes, that is correct. Now you can use it with the otlp client on the Jeager side. We can remove the Jeager option and write this information to Docs. I can open PR for the remove Jeager client side. Or we can additionally add HTTP as an option to grpc |
I think we should start by documenting the Jaeger exporter as deprecated first, then remove it in a future release, so that anybody who is currently using it has some warning before it disappears. Let's change the comment on the config section to be prefixed with
That'll show up in the full configuration docs at https://docs.cerbos.dev/cerbos/latest/configuration/#_full_configuration Then, let's also update the docs with a similar note about using the OTLP exporter instead.
Let's also move the OTLP section above the Jaeger one so it has more prominence. That'll show up at https://docs.cerbos.dev/cerbos/latest/configuration/tracing I think it would be reasonable to support HTTP as well as gRPC. We could add a https://github.com/cerbos/cerbos/blob/main/internal/observability/tracing/conf.go#L50-L53 Hope that helps you get started @muratmirgun! Thanks for contributing 🙇 |
Thanks for the info. I am working on it 🚀 |
Add ability to configure OTLP trace exporters with more options such as the choice of protocols, sampler configuration, TLS settings etc. As part of this change, the `tracing` configuration block in the Cerbos configuration file has been completely deprecated with the aim of removing it in the release after next. This is because of the following reasons: - Jaeger native protocol is no longer supported by the Otel SDK. - The Otel specification defines standard environment variables that can be used to configure OTLP exporters. Trying to replicate all possible configuration options in our configuration would be brittle and just complicate our code and documentation for not much benefit. Fixes #1784 Part of #341 --------- Signed-off-by: Charith Ellawala <charith@cerbos.dev>
The text was updated successfully, but these errors were encountered: