Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API version for initial release #35

Closed
charithe opened this issue Mar 30, 2021 · 3 comments · Fixed by #41
Closed

API version for initial release #35

charithe opened this issue Mar 30, 2021 · 3 comments · Fixed by #41
Labels
area/documentation Improvements or additions to documentation kind/question Further information is requested
Milestone

Comments

@charithe
Copy link
Contributor

Currently the apiVersion field is set to cerbos.dev/v1. Bearing in mind that the API is not stable yet and that we could potentially have a schema/API registry hosted at the address in the future, I think the value should change to api.cerbos.dev/v1beta1. Thoughts @emreb?

@charithe charithe added area/documentation Improvements or additions to documentation kind/question Further information is requested labels Mar 30, 2021
@emreb
Copy link
Contributor

emreb commented Apr 4, 2021

Perhaps we should think about the /check vs /policy differently. I do not foresee the /check endpoint changing much.

@charithe
Copy link
Contributor Author

charithe commented Apr 5, 2021

This is about the apiVersion field in the policy. I am proposing to change the following:

apiVersion: cerbos.dev/v1
resourcePolicy:
  resource: leave_request
...

to

apiVersion: api.cerbos.dev/v1beta1
resourcePolicy:
  resource: leave_request
...

@charithe charithe added this to the MVP milestone Apr 5, 2021
@emreb
Copy link
Contributor

emreb commented Apr 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation kind/question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants