Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename computation in derived roles to condition #49

Closed
charithe opened this issue Apr 13, 2021 · 0 comments · Fixed by #51
Closed

Rename computation in derived roles to condition #49

charithe opened this issue Apr 13, 2021 · 0 comments · Fixed by #51
Labels
area/code-quality
Milestone
MVP

Comments

@charithe
Copy link
Contributor

In derived roles, conditions are actually defined under the computation key. This is different from resource and principal policies where the key is condition. For consistency, computation should be renamed to condition as well.
@charithe charithe added this to the MVP milestone Apr 13, 2021
@charithe charithe mentioned this issue Apr 13, 2021
Merged
charithe added a commit that referenced this issue Apr 13, 2021
@charithe
breaking: Rename computation to condition (#51)
7095677 
Changes the `computation` field in derived roles to `condition` to be
consistent with the other policy types.

Fixes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-quality
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

breaking: Rename computation to condition
1 participant
@charithe