fix: Rewrite log level change without Go 1.19 features #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`atomic.Bool` is only available in Go 1.19 and users on older versions of Go won't be able to download the SDK because of that. Since `atomic.Bool` is not crucial for a correct implementation, we can revert it this time. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
+ Coverage 54.68% 54.89% +0.21%
==========================================
Files 111 111
Lines 12561 12563 +2
==========================================
+ Hits 6869 6897 +28
+ Misses 5120 5093 -27
- Partials 572 573 +1
|
haines
previously approved these changes
Nov 15, 2022
|
Do we need to change |
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Good catch! Didn't realise that Renovate changed it to 1.19. |
haines
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic.Boolis only available in Go 1.19 and users on older versionsof Go won't be able to download the SDK because of that. Since
atomic.Boolis not crucial for a correct implementation, we can revertit this time.
Signed-off-by: Charith Ellawala charith@cerbos.dev