fix: Mark /tmp as a container volume #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mark `/tmp` and `/.cache` as volumes so that the directories are automatically created within the container. Ideally `/tmp` should be a `tmpfs` mount and `/.cache` should be a persistent mount, especially when the `bundle` driver is in use. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
+ Coverage 53.33% 53.52% +0.19%
==========================================
Files 128 128
Lines 14449 14449
==========================================
+ Hits 7706 7734 +28
+ Misses 6070 6041 -29
- Partials 673 674 +1 |
haines
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly mark
/tmpand/.cacheas volumes so that the directoriesare automatically created within the container.
Ideally
/tmpshould be atmpfsmount and/.cacheshould be apersistent mount, especially when the
bundledriver is in use.Signed-off-by: Charith Ellawala charith@cerbos.dev