enhancement(helm): Upgrade to HPA v2 API #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The beta versions of `HorizontalPodAutoScaler` v2 will be dropped in Kubernetes 1.26 and some distributions such as GKE are warning about it now. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
haines
previously approved these changes
Apr 26, 2023
|
Should we add a |
|
Good idea! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 53.34% 53.47% +0.12%
==========================================
Files 128 128
Lines 14449 14449
==========================================
+ Hits 7708 7726 +18
+ Misses 6068 6049 -19
- Partials 673 674 +1 |
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
haines
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beta versions of
HorizontalPodAutoScalerv2 will be dropped inKubernetes 1.26 and some distributions such as GKE are warning about it
now.
Signed-off-by: Charith Ellawala charith@cerbos.dev