Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Handle schemas folder being in wrong place with more verbose error #1550

Merged
merged 1 commit into from Apr 27, 2023

Conversation

oguzhand95
Copy link
Member

resolves #1539

@oguzhand95 oguzhand95 added the kind/enhancement New feature or request label Apr 27, 2023
@oguzhand95 oguzhand95 self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1550 (eb68f55) into main (41a1753) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
+ Coverage   53.33%   53.51%   +0.18%     
==========================================
  Files         128      128              
  Lines       14449    14452       +3     
==========================================
+ Hits         7706     7734      +28     
+ Misses       6070     6043      -27     
- Partials      673      675       +2     
Impacted Files Coverage Δ
internal/storage/index/builder.go 84.97% <100.00%> (+7.35%) ⬆️

... and 3 files with indirect coverage changes

@oguzhand95 oguzhand95 marked this pull request as ready for review April 27, 2023 12:47
internal/storage/index/builder.go Outdated Show resolved Hide resolved
internal/storage/index/builder.go Outdated Show resolved Hide resolved
…bose error

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 merged commit 6a24371 into cerbos:main Apr 27, 2023
19 checks passed
@oguzhand95 oguzhand95 deleted the index branch April 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more verbose error message if _schemas directory is not at storage root
2 participants