Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Add CEL math extension #1569

Merged
merged 1 commit into from May 10, 2023
Merged

Conversation

oguzhand95
Copy link
Member

@oguzhand95 oguzhand95 commented May 9, 2023

Adds math.greatest and math.least macros introduced in cel-go@v0.13.0.

#1561

@oguzhand95 oguzhand95 added the kind/enhancement New feature or request label May 9, 2023
@oguzhand95 oguzhand95 self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1569 (2350574) into main (d0b3f79) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 2350574 differs from pull request most recent head 9351410. Consider uploading reports for the commit 9351410 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   53.32%   53.53%   +0.21%     
==========================================
  Files         130      128       -2     
  Lines       14605    14454     -151     
==========================================
- Hits         7788     7738      -50     
+ Misses       6132     6041      -91     
+ Partials      685      675      -10     
Impacted Files Coverage Δ
internal/conditions/cel.go 79.51% <100.00%> (+0.50%) ⬆️

... and 8 files with indirect coverage changes

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 marked this pull request as ready for review May 10, 2023 08:14
@oguzhand95 oguzhand95 merged commit 60ff224 into cerbos:main May 10, 2023
17 checks passed
@oguzhand95 oguzhand95 deleted the math branch May 10, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants