bug: Fix nil deref while handling changed files #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory watcher was not sending the contents of the changed policy to the disk index when it detected a file system event. Because the index was trying to access the non-existent policy data it was crashing with a nil pointer deref. This change includes the following: - A fix for the bug described above - Extra tests to exercise the directory watcher - Re-introduce Mockery to generate mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory watcher was not sending the contents of the changed policy
to the disk index when it detected a file system event. Because the
index was trying to access the non-existent policy data it was crashing
with a nil pointer deref.
This change includes the following:
Fixes #156