Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use IncludeMetadata option on all gRPC requests #1586

Merged
merged 2 commits into from May 16, 2023

Conversation

oguzhand95
Copy link
Member

resolves #1585

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 added the kind/bug Something isn't working label May 15, 2023
@oguzhand95 oguzhand95 self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1586 (2e9b1a4) into main (3b64da7) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
+ Coverage   53.35%   53.63%   +0.27%     
==========================================
  Files         130      129       -1     
  Lines       14631    14622       -9     
==========================================
+ Hits         7806     7842      +36     
+ Misses       6139     6092      -47     
- Partials      686      688       +2     
Impacted Files Coverage Δ
client/client.go 53.11% <100.00%> (+0.46%) ⬆️
client/tests.go 98.51% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 marked this pull request as ready for review May 15, 2023 16:49
@oguzhand95 oguzhand95 merged commit b49d27d into cerbos:main May 16, 2023
19 checks passed
@oguzhand95 oguzhand95 deleted the client branch May 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IncludeMeta option not inspected in all grpc client requests
2 participants