fix: Return correct error code when store is invalid #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning `Internal` error, return `FailedPrecondition` when the requested policy has a compilation error. Fixes cerbos#1590 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
charithe
commented
May 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
==========================================
+ Coverage 53.25% 53.44% +0.18%
==========================================
Files 130 130
Lines 14683 14685 +2
==========================================
+ Hits 7820 7848 +28
+ Misses 6174 6147 -27
- Partials 689 690 +1
|
haines
reviewed
May 18, 2023
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
haines
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning
Internalerror, returnFailedPreconditionwhenthe requested policy has a compilation error. We already had this special case handled in the
CheckResourceSetRPC but, for some reason, it had been omitted in the other RPCs.Fixes #1590
Signed-off-by: Charith Ellawala charith@cerbos.dev