Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update e2e overlay test seed file with newly added output data #1611

Merged

Conversation

Sambigeara
Copy link
Contributor

The standard e2e db storage driver tests rely on the mutable tests to run prior to check tests in order to populate the DB with expected data. The overlay driver doesn't support mutable operations, hence the need for the seed data (as the test uses a mutable baseDriver). I forgot to update this data when introducing the recent output changes. This fixes that by adding the additional data.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1611 (6e393f7) into main (ded521c) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
+ Coverage   53.11%   53.30%   +0.18%     
==========================================
  Files         130      130              
  Lines       14765    14765              
==========================================
+ Hits         7843     7870      +27     
+ Misses       6229     6200      -29     
- Partials      693      695       +2     

see 5 files with indirect coverage changes

Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have some kind of a script or a "Golden" output generator that we can run to generate this file when the policies change?

@Sambigeara
Copy link
Contributor Author

That's a good idea. I've thus far been running the postgres test and taking a data-only dump from the resultant db (then doing a bit of manual tidying). I'll raise a separate ticket to try to automate this somehow.

@Sambigeara Sambigeara merged commit 0f78104 into cerbos:main Jun 1, 2023
20 checks passed
@Sambigeara Sambigeara deleted the fix/e2e-overlay-output-seed-data branch June 1, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants