Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests to check fixture loading from testdata #1877

Merged
merged 1 commit into from Nov 14, 2023

Conversation

charithe
Copy link
Contributor

If the fixture files were not named
testdata/{auxdata,principals,resources}.yaml Cerbos versions up to
0.31 panicked. That's been inadvertently fixed in main but it needs
tests to make sure there are no regressions.

Signed-off-by: Charith Ellawala charith@cerbos.dev

If the fixture files were not named
`testdata/{auxdata,principals,resources}.yaml` Cerbos versions up to
0.31 panicked. That's been inadvertently fixed in `main` but it needs
  tests to make sure there are no regressions.

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Copy link
Contributor

@dbuduev dbuduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charithe charithe enabled auto-merge (squash) November 14, 2023 07:24
@charithe charithe merged commit cf21eb0 into cerbos:main Nov 14, 2023
15 of 17 checks passed
@charithe charithe deleted the chore/test-fixture-filenames branch November 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants