fix: Skip compile cache if first candidate doesn't exist #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lenient scope search is enabled and we have a set of candidates to search for, we incorrectly search the cache for all of those and return the first one found. If we don't find the first candidate in the cache, we should just hit the store because it could have been added to the repo since we last looked for it. Fixes cerbos#1846 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
haines
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lenient scope search is enabled and we have a set of candidates to
search for, we incorrectly search the cache for all of those and return
the first one found. If we don't find the first candidate in the cache,
we should just hit the store because it could have been added to the
repo since we last looked for it.
Fixes #1846
Signed-off-by: Charith Ellawala charith@cerbos.dev