New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(refactor)!: Refactor policy Admin API endpoints #516
Conversation
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
87e8de2
to
67da787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that instead of the FQN, we should let the human readable identifier be the tuple (kind, name, version)
which can be represented as a dot separated string (resource.leave_request.default
). That shields the users from being exposed to internal implementation details and allow them to work with the concrete data they deal with in the policy files.
Also, I believe the cerbosctl
commands need to be updated to handle this change as well. I think we are now losing the ability to filter and sort policies by fields.
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
…tore Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
1a42d0c
to
cbb67ba
Compare
@charithe
MySQL documentation suggests executing the following makes MySQL recognize || as concatenation operator. (By default, MySQL treats || as OR.) Let's discuss whether this could be an option or not. |
d6de39c
to
b278949
Compare
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
b278949
to
661462b
Compare
It's a shame that MySQL doesn't conform to ANSI SQL. We'll have to figure out a way to generate the correct |
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽 Just a couple of small nits to address.
Will do a bit of testing tomorrow morning and we can merge this afterwards.
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
Description
Fixes #487
Checklist
git commit -s ...
) to provide the DCO