Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow generation of hash functions for optional fields #20

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Feb 16, 2024

Description

Fixes #19

So this changes all the field accessors to use Get() instead of accessing them directly. Let me know if you think that's undesirable. It was a shortcut I decided to make to reduce the amount of branching the code needs to do for different fields.

Checklist

  • The PR title has the correct prefix
  • PR is linked to the corresponding issue
  • All commits are signed-off (git commit -s ...) to provide the DCO

Signed-off-by: Amir Omidi <amir@aaomidi.com>
@aaomidi aaomidi marked this pull request as ready for review February 20, 2024 19:27
@aaomidi aaomidi changed the title Add support optional fields feat: allow generation of hash functions for optional fields Feb 20, 2024
Copy link
Contributor

@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charithe charithe merged commit 63dbd4f into cerbos:main Mar 11, 2024
2 checks passed
@aaomidi
Copy link
Contributor Author

aaomidi commented Mar 11, 2024

Any thoughts on getting a release with the latest changes?

@aaomidi aaomidi deleted the amir/support-optional branch March 11, 2024 16:23
@charithe
Copy link
Contributor

I've tagged v0.3.0 so you should be able to go get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for optional fields
2 participants