Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statediff builder unit tests with internalized leaf nodes #350

Merged
merged 3 commits into from Mar 28, 2023

Conversation

i-norden
Copy link
Collaborator

@i-norden i-norden commented Mar 28, 2023

Finally...

Closes #338

We now can demonstrate in unit tests local to this repo that we are properly handling internalized leaf nodes.

@i-norden i-norden requested a review from roysc March 28, 2023 19:30
@i-norden i-norden force-pushed the ian/v5_dev branch 2 times, most recently from 241f875 to ceb1c94 Compare March 28, 2023 19:34
@i-norden i-norden merged commit e577ea3 into v1.10.26-statediff-v5 Mar 28, 2023
5 checks passed
Copy link

@roysc roysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How did you search for the nodes sharing a prefix? Might be a useful script to have around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants