367: Check if the statediff is already in progress or completed. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-norden
approved these changes
Jun 1, 2023
| // Writes a state diff from the current block, parent state root, and provided params | ||
| func (sds *Service) writeStateDiff(block *types.Block, parentRoot common.Hash, params Params) error { | ||
| if granted, relinquish := sds.claimExclusiveAccess(block); granted { |
dboreham
approved these changes
Jun 1, 2023
telackey
added a commit
that referenced
this pull request
Jun 1, 2023
telackey
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #367.
Add two checks:
Only allow a single statediff of a block hash+number at a time.
Do not state diff if that block hash+number already exists in the DB.