396: Don't skip any blocks if the head of the chain advances by more than one block. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one block.
telackey
changed the title
telackey
changed the title
telackey
changed the title
i-norden
approved these changes
Jul 6, 2023
| defaultStatediffMetrics.lastEventHeight.Update(int64(nextHeight)) | ||
| } | ||
| } else { | ||
| log.Warn("WriteLoop: received unexpected block from the past", "block height", nextHeight, "last height", lastHeight) |
There was a problem hiding this comment.
Will be interesting to see if/how often this occurs.
| @@ -438,6 +471,8 @@ func (sds *Service) Loop(chainEventCh chan core.ChainEvent) { | |||
| select { | |||
| //Notify chain event channel of events | |||
| case chainEvent := <-chainEventCh: | |||
| // TODO: Do we need to track the last streamed block as we do for the WriteLoop so that we can detect | |||
There was a problem hiding this comment.
For correctness we should, but nothing currently uses the streaming functionality (and won't in the foreseeable future) so we don't need to. We should consider removing the statediff streaming during the pluggeth port @roysc.
github-cerc-io
pushed a commit
to cerc-io/plugeth-statediff
that referenced
this pull request
Oct 2, 2023
Port of cerc-io/go-ethereum#399 and cerc-io/go-ethereum#397. Co-authored-by: Thomas E Lackey <telackey@bozemanpass.com> Reviewed-on: https://git.vdb.to/cerc-io/plugeth-statediff/pulls/8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #396 shows, we can get scenarios when the chain advances by more than a single block, but the event which is seen by the WriteLoop will only be for the new head block--however many blocks in advance it is--allowing gaps to open in the statediffing.
This code will detect and trigger statediffing for the skipped blocks. The functionality is similar to the previous "head gap" filling code. Similar enough that we are able to remove that code and allow this to cover both cases.