Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema updates #27

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Schema updates #27

merged 2 commits into from
Nov 26, 2021

Conversation

i-norden
Copy link
Collaborator

@i-norden i-norden commented Nov 25, 2021

Final schema review and refactor:

I'm also wondering if we really need to store TxData and LogData blown out into transaction_cids and log_cids, respectively. I can imagine some instances where we would want to search on them but they also are the two largest fields of these types to duplicate.

…t when we convert to .csv and load using COPY FROM it doesn't need to sort
@AFDudley
Copy link

I'm also wondering if we really need to store TxData and LogData blown out into transaction_cids and log_cids, respectively. I can imagine some instances where we would want to search on them but they also are the two largest fields of these types to duplicate.

These are fairly complex design questions that have to do with how "eth watcher" (which is what this service should actually be called) interacts with the other watchers in the system.

@i-norden
Copy link
Collaborator Author

@AFDudley Going to leave tx_data and log_data in for now, it would be relatively quick and cheap to go and drop these columns from the database later on but extremely expensive to add them back.

@i-norden i-norden merged commit 8fe193b into postgres_refactor Nov 26, 2021
@github-cerc-io github-cerc-io deleted the schema_updates branch October 2, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants