Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 incompatible #29

Closed
frenck opened this issue Feb 7, 2022 · 1 comment
Closed

Python 3.10 incompatible #29

frenck opened this issue Feb 7, 2022 · 1 comment

Comments

@frenck
Copy link

frenck commented Feb 7, 2022

Hi! 👋

I've been working on upgrading Home Assistant to Python 3.10, and noticed this package isn't compatible with Python 3.10.

Python upgrade PR: home-assistant/core#59729

Error from tests:

  File "/__w/core/core/venv/lib/python3.10/site-packages/velbusaio/protocol.py", line 51, in __init__
  self._send_queue = asyncio.Queue(loop=self._loop)
  TypeError: As of 3.10, the *loop* parameter was removed from Queue() since it is no longer necessary

A quick sneak peek/search revealed more cases of passing the loop argument:

https://github.com/Cereal2nd/velbus-aio/search?q=loop

Could this be fixed? 🙏 ❤️

Thanks!

../Frenck

@Cereal2nd
Copy link
Owner

Started working on this
https://github.com/Cereal2nd/velbus-aio/compare/py310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants