Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): support latest Cerebral 0.33 and new releases #7

Merged
merged 3 commits into from
Apr 19, 2016

Conversation

christianalfoni
Copy link
Contributor

No description provided.

@Guria
Copy link
Contributor

Guria commented Apr 17, 2016

why not to use alias instead of factory?

@Guria
Copy link
Contributor

Guria commented Apr 17, 2016

@Guria
Copy link
Contributor

Guria commented Apr 17, 2016

set cerebral@0.33.31 as minimal peerVersion

@Guria Guria mentioned this pull request Apr 17, 2016
@Guria
Copy link
Contributor

Guria commented Apr 17, 2016

port this changes too

@christianalfoni
Copy link
Contributor Author

  1. Do not have access to the alias in 0.34 inside actions (without adding a context provider for modules)
  2. Changed to immediate now :)
  3. Changed minimal version
  4. Moved over the IF thingy there as well. Tests and deps was up to date

@@ -166,6 +169,15 @@ module.exports = function (options) {

module.alias(MODULE)

if (module.addContextProvider) {
controller.addContextProvider({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have MODULE const. How about:

var context = {}
context[MODULE] = { path: module.path }
controller.addContextProvider(context)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@christianalfoni
Copy link
Contributor Author

Okay, implemented all your suggestions, very good :)

@Guria
Copy link
Contributor

Guria commented Apr 18, 2016

LGTM

@Guria
Copy link
Contributor

Guria commented Apr 19, 2016

please squash and use:

"peerDependencies": {
  "cerebral": "^0.33.31 || ^0.34.0-rc.4"
},

@Guria Guria merged commit f21c048 into master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants