-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): support latest Cerebral 0.33 and new releases #7
Conversation
why not to use alias instead of factory? |
https://github.com/cerebral/cerebral-module-recorder/blob/newContextSignals/index.js#L33 |
set |
port this changes too |
dc2e855
to
d79670c
Compare
|
d79670c
to
ec69d08
Compare
@@ -166,6 +169,15 @@ module.exports = function (options) { | |||
|
|||
module.alias(MODULE) | |||
|
|||
if (module.addContextProvider) { | |||
controller.addContextProvider({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have MODULE const. How about:
var context = {}
context[MODULE] = { path: module.path }
controller.addContextProvider(context)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
ec69d08
to
2803a62
Compare
Okay, implemented all your suggestions, very good :) |
LGTM |
please squash and use: "peerDependencies": {
"cerebral": "^0.33.31 || ^0.34.0-rc.4"
}, |
a91a2f0
to
3352e86
Compare
No description provided.