refactor(function-tree): improve error message on missing promise or …

…path
cerebral · Dec 17, 2016 · 24c26a1 · 24c26a1
1 parent 5b8ecb8
commit 24c26a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/function-tree/src/FunctionTree.test.js b/packages/function-tree/src/FunctionTree.test.js
@@ -172,7 +172,7 @@ describe('FunctionTree', () => {
       })
     })
   })
-  it('should give error when path and no path returned', () => {
+  it('should give error when path and no path returned', (done) => {
     function actionA () {
       return {
         foo: 'bar'
@@ -185,8 +185,9 @@ describe('FunctionTree', () => {
         success: []
       }
     ]
-    execute.once('error', () => {
-      assert.ok(true)
+    execute.once('error', (error) => {
+      assert.ok(error.message.match(/needs to be a path or a Promise/))
+      done()
     })
     execute(tree)
   })

diff --git a/packages/function-tree/src/index.js b/packages/function-tree/src/index.js
@@ -116,7 +116,7 @@ class FunctionTreeExecution extends EventEmitter {
       functionTree.emit('functionEnd', execution, funcDetails, payload)
       next(result.toJS())
     } else if (funcDetails.outputs) {
-      let error = new Error('The result ' + JSON.stringify(result) + ' from function ' + funcDetails.name + ' needs to be a path')
+      let error = new Error('The result ' + JSON.stringify(result) + ' from function ' + funcDetails.name + ' needs to be a path or a Promise')
 
       errorCallback(error)
     } else if (isValidResult(result)) {