Some clean up #1283
Merged
Some clean up #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes more sense to mark the PR as WIP.
|
There seems to be something weird going on with the history here? :) |
|
@henri-hulski you need to rebase upstream/next |
|
Sorry I made the PR from command line and forgot to add the $ git pull-request -b next(You need Hub to do this.) But there's still something wrong. Seems that @christianalfoni has merged in master. :) |
henri-hulski
force-pushed
the
cleanup
branch
from
762d688
to
8fd4d7e
Compare
|
Ok, it's fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.