Rebase/274 Add support for creating resources with polymorphic has one. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the serialization of `has_many` relationships. I'm not sure if it handles every situation that people are imagining but it addresses the primary issue that I saw which was the need to return the correct type for the individual resources. As with the solution for polymorphic `has_one` relationships, you need to add a `Resource` and `Controller` class for each potential type. I didn't address anything new related to creating or updating `has_many` relationships in this commit.
`foreign_key_value` is only called for has one associations for now.
|
I just tested on a ~large app that depends on the polymorphic functionality and the tests passed. I also reviewed the two methods that you removed and that's fine. They aren't used. |
lgebhardt
added a commit
that referenced
this pull request
Jul 5, 2015
Rebase/274 Add support for creating resources with polymorphic has one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #274.
@barelyknown @ggordon please review to make sure I didn't miss something.
I also removed the code that wasn't being covered by the tests. If you could check that out and make sure it won't affect things in your code that would be great. If we do need it in there we should make sure we test it.